Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crates io v0.18.0 #792

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Crates io v0.18.0 #792

wants to merge 5 commits into from

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Jul 9, 2024

DO NOT MERGE
Some tests cannot compile due to the fact that two, non-compatible versions of sp_runtime are involved during the build. The root cause of this is the fact that kitchensink-runtime requires old dependencies. Overall this not very nice as we cannot properly test a release

  • kitchensink-runtime is not being published to crates.io
  • This was already a problem with 0.17.0. See Crates io v0.17.0 #742
    • Actually even more tests were failing
  • I don't understand why this is not a problem when building on master
    • On master of polkadot-sdk the version numbers don't seem to get updated automatically
      • For example sp-core is at v28.0.0 on master whereas on the the release-branch it is at v34.0.0

@Niederb Niederb self-assigned this Jul 9, 2024
@Niederb Niederb requested a review from masapr July 9, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants